gjm
d4a9442e30
C++（cad_mcp_plugins）：
- 新增 bvh.h：header-only 2D BVH（质心中位分割，叶<=4，SelfPairs 交叉对枚举）
- 新增 find_collisions.cpp：粗筛 AABB 相交实体对，附重叠盒 + 逐轴重叠比 ratio
（= 逐轴重叠长/较短长 之积，退化轴取 1.0），按 ratio 降序 + 分页；
narrow=true 只对返回页跑 intersectWith 细筛（附 exact）
- 容器过滤（关键）：图框块/分区边界会与一切相交，用重叠【度】判定
deg >= max(exclude_container_deg=8, exclude_container_frac=0.25 * 其他实体数)，
与图幅/缩放无关；被剔除者在 excluded_containers 里如实报告
（初版用面积判据对多图框并排失效：3 框只占并集 27/13/7% 全部漏过，
全模型 163 对噪声；改度判据后图框 deg=35/25/23 vs 其余 deg<=3，分离干净）
- cmakelists.txt + 两个 mcp_config.json 注册（28 工具）
agent 侧（Python）：
- cad_tools.READ_ONLY_TOOLS += find_collisions（受控子循环可调用）
- checks.check_collisions + run_deterministic_checks（受 CHECK_COLLISIONS 开关，默认关）
- config += CHECK_COLLISIONS=False / COLLISION_MIN_OVERLAP=0.5
- checklist.py / review_checklist.json += 「干涉/碰撞」类别（high）+ 提示词协议
（先 find_collisions 拿候选 → inspect_region 目视确认；AABB 相交 != 真干涉）
验证：
- verify_collisions.py 17/17 PASS：全模型候选 163→80（全部 ratio=0.000），
min_overlap=0.5 → 0 对；逐图框 0 对；narrow top-5 中 4 条 exact=true；
--inject 注入深重叠矩形报出 ratio=0.902 并清理 2/2
- pytest 355 passed（新增 12 项）
- 端到端：LLM 主动调用 find_collisions{min_overlap:0.2,narrow:true,window:<图框>}，未误报
160 lines
5.8 KiB
Python
160 lines
5.8 KiB
Python
"""`dwg_review.config` 单元测试（只验证纯函数与常量类型，不依赖真实环境变量）。"""
|
|
|
|
import os
|
|
|
|
from dwg_review import config
|
|
|
|
|
|
def test_resolve_path_relative_uses_project_root():
|
|
assert config._resolve_path("reports") == config.PROJECT_ROOT / "reports"
|
|
|
|
|
|
def test_resolve_path_absolute_unchanged(tmp_path):
|
|
assert config._resolve_path(str(tmp_path)) == tmp_path
|
|
|
|
|
|
def test_project_root_is_repo_root():
|
|
assert (config.PROJECT_ROOT / "dwg_review" / "config.py").is_file()
|
|
|
|
|
|
def test_read_env_prefers_environ(monkeypatch):
|
|
monkeypatch.setenv("CAD_TEST_ENV_PROBE", "hello")
|
|
assert config._read_env("CAD_TEST_ENV_PROBE") == "hello"
|
|
|
|
|
|
def test_read_env_missing_returns_empty(monkeypatch):
|
|
monkeypatch.delenv("CAD_TEST_DEFINITELY_MISSING_XYZ", raising=False)
|
|
assert config._read_env("CAD_TEST_DEFINITELY_MISSING_XYZ") == ""
|
|
|
|
|
|
def test_read_bool_defaults_when_unset(monkeypatch):
|
|
monkeypatch.delenv("CAD_TEST_BOOL_UNSET", raising=False)
|
|
assert config._read_bool("CAD_TEST_BOOL_UNSET", True) is True
|
|
assert config._read_bool("CAD_TEST_BOOL_UNSET", False) is False
|
|
|
|
|
|
def test_read_bool_empty_string_uses_default(monkeypatch):
|
|
monkeypatch.setenv("CAD_TEST_BOOL_EMPTY", " ")
|
|
assert config._read_bool("CAD_TEST_BOOL_EMPTY", True) is True
|
|
|
|
|
|
def test_read_bool_truthy_and_falsy(monkeypatch):
|
|
for raw in ("1", "true", "TRUE", "Yes", "on"):
|
|
monkeypatch.setenv("CAD_TEST_BOOL", raw)
|
|
assert config._read_bool("CAD_TEST_BOOL", False) is True
|
|
for raw in ("0", "false", "no", "off", "nope"):
|
|
monkeypatch.setenv("CAD_TEST_BOOL", raw)
|
|
assert config._read_bool("CAD_TEST_BOOL", True) is False
|
|
|
|
|
|
def test_has_api_key_reflects_module_value(monkeypatch):
|
|
monkeypatch.setattr(config, "API_KEY", "")
|
|
assert config.has_api_key() is False
|
|
monkeypatch.setattr(config, "API_KEY", "sk-x")
|
|
assert config.has_api_key() is True
|
|
|
|
|
|
def test_has_api_key_ignores_whitespace(monkeypatch):
|
|
monkeypatch.setattr(config, "API_KEY", " ")
|
|
assert config.has_api_key() is False
|
|
|
|
|
|
def test_constants_have_expected_types():
|
|
assert isinstance(config.HOST, str)
|
|
assert isinstance(config.PORT, int)
|
|
assert isinstance(config.CALL_TIMEOUT, float)
|
|
assert isinstance(config.CALL_RETRIES, int)
|
|
assert isinstance(config.MAX_FRAME_BYTES, int)
|
|
assert isinstance(config.IMAGE_MAX_EDGE, int)
|
|
assert isinstance(config.IMAGE_FORMAT, str)
|
|
assert isinstance(config.CHECKLIST_PATH, type(config.PROJECT_ROOT))
|
|
|
|
|
|
def test_credibility_constants_have_expected_types():
|
|
assert isinstance(config.DETERMINISTIC_CHECKS, bool)
|
|
assert isinstance(config.VALIDATE_HANDLES, bool)
|
|
assert isinstance(config.CHECK_UNCLOSED_POLYLINES, bool)
|
|
assert isinstance(config.ZERO_LENGTH_TOLERANCE, float)
|
|
assert isinstance(config.DUP_TOLERANCE, float)
|
|
assert isinstance(config.DUP_GROUP_LIMIT, int)
|
|
assert isinstance(config.CHECK_COLLISIONS, bool)
|
|
assert isinstance(config.COLLISION_MIN_OVERLAP, float)
|
|
|
|
|
|
def test_tiling_constants_have_expected_types():
|
|
assert isinstance(config.TILING_ENABLED, bool)
|
|
assert isinstance(config.TEXT_HEIGHT_MM, float)
|
|
assert isinstance(config.TEXT_READABLE_PX, int)
|
|
assert isinstance(config.LINE_READABLE_PX, int)
|
|
assert isinstance(config.TILE_MAX_COUNT, int)
|
|
assert isinstance(config.TILE_OVERLAP, float)
|
|
assert isinstance(config.HEATMAP_CELL_DIV, int)
|
|
assert isinstance(config.HEATMAP_CLUSTER_DILATE, int)
|
|
assert isinstance(config.HEATMAP_MAX_AREA_FRAC, float)
|
|
|
|
|
|
def test_tiling_defaults_are_sane():
|
|
# 默认启用瓦片规划；可读下限为正；成本上界为正
|
|
assert config.TILING_ENABLED is True
|
|
assert config.TEXT_HEIGHT_MM > 0
|
|
assert config.TEXT_READABLE_PX > 0
|
|
assert config.LINE_READABLE_PX > 0
|
|
assert config.TILE_MAX_COUNT > 0
|
|
assert config.HEATMAP_CELL_DIV > 0
|
|
|
|
|
|
def test_review_obs_images_default_is_sane():
|
|
# 审查子循环回灌截图上限：须为正，且不低于旧硬编码值 3
|
|
assert config.REVIEW_OBS_IMAGES >= 3
|
|
|
|
|
|
def test_inspect_defaults_are_sane():
|
|
# agent 侧虚拟工具默认启用；单次瓦片上限为正
|
|
assert config.INSPECT_ENABLED is True
|
|
assert config.INSPECT_MAX_TILES >= 1
|
|
|
|
|
|
def test_drawing_area_constants_have_expected_types():
|
|
assert isinstance(config.DRAWING_AREA_MAXIMIZE, bool)
|
|
assert isinstance(config.DRAWING_AREA_ENTER_WAIT, float)
|
|
assert isinstance(config.DRAWING_AREA_RESTORE_WAIT, float)
|
|
|
|
|
|
def test_drawing_area_defaults_are_sane():
|
|
# 默认开启绘图区最大化；还原等待须盖过插件内 700ms 的延迟还原（实测 1.0s 才收敛）
|
|
assert config.DRAWING_AREA_MAXIMIZE is True
|
|
assert config.DRAWING_AREA_ENTER_WAIT >= 0
|
|
assert config.DRAWING_AREA_RESTORE_WAIT >= 1.2
|
|
|
|
|
|
def test_credibility_defaults_are_on():
|
|
# 默认开启，保证默认拿到可信度收益
|
|
assert config.DETERMINISTIC_CHECKS is True
|
|
assert config.VALIDATE_HANDLES is True
|
|
assert config.CHECK_UNCLOSED_POLYLINES is True
|
|
|
|
|
|
def test_collision_defaults_are_sane():
|
|
# 干涉粗筛默认关闭（AABB 相交噪声大，改由 LLM 按需调用）；
|
|
# 阈值须落在 [0,1]（重叠比是乘积，可能为 0）
|
|
assert config.CHECK_COLLISIONS is False
|
|
assert 0.0 <= config.COLLISION_MIN_OVERLAP <= 1.0
|
|
|
|
|
|
def test_checklist_path_resolves_relative_to_root():
|
|
assert config.CHECKLIST_PATH.name == "review_checklist.json"
|
|
assert config.CHECKLIST_PATH.parent == config.PROJECT_ROOT
|
|
|
|
|
|
def test_port_default_matches_baseline():
|
|
# 基座固定监听 127.0.0.1:8080；若此值被改动，请同步更新基座与文档。
|
|
assert config.HOST == "127.0.0.1"
|
|
assert config.PORT == 8080
|
|
|
|
|
|
def test_os_name_guard_in_read_env(monkeypatch):
|
|
# 非 Windows 平台不应触碰注册表
|
|
monkeypatch.setattr(os, "name", "posix")
|
|
monkeypatch.delenv("CAD_TEST_ENV_PROBE2", raising=False)
|
|
assert config._read_env("CAD_TEST_ENV_PROBE2") == ""
|